Re: [PATCH 4/4] video/imx: always initialize offscreenbuf member

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/17/2013 12:56 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 07:32 Thu 17 Jan     , Daniel Mierswa wrote:
>> +	/*
>> +	 * sc.offscreenbuf is dangling here, if no offscreen buffer was
>> +	 * requested, so set it to NULL otherwise the free in fd_close
>> +	 * will cause undefined behaviour
>> +	 */
>> +	if (!offscreen)
>> +		sc.offscreenbuf = NULL;
>> +
> NAck
> 
> this is already done by memset
> 
> Best Regards,
> J.
>>  	if (sc.offscreenbuf) {
>>  		if (do_bg)
>>  			memset_pixel(&info, sc.offscreenbuf, bg_color,

Huh? I don't get it.

-- 
Mierswa, Daniel

If you still don't like it, that's ok: that's why I'm boss. I simply know better than you do.
               --- Linus Torvalds, comp.os.linux.advocacy, 1996/07/22

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox


[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux