On Thu, Nov 01, 2012 at 06:37:16PM +0100, Robert Jarzmik wrote: > Hi everyone, > > This patchset aims at changing the Y-Modem protocol implementation. > You have already seen the RFC version, this is the next version, which : > - provides a much more tested version > - is ready for review > > The following comments have been taken into account : > - Antony: testing on a serial line > - Sascha: split between protocol and commands > - Jean-Christophe: kermit protocol change > > So before doing the real review, could I ask of you : > - Antony: could you redo your test over a serial line by applying only > the first patch so that you can compare loady and loady2 ? > Don't use "loady2 -g", as Y-Modem/G protocol requires a > lossless line (USB), and a serial line cannot guarantee it. > - Sascha: does the split command/protocol suit you ? Almost, yes. The backend support should go to common/ or lib/ and get its own (invisible) Kconfig symbol which is then selected by the command. So: lib/ or common/: config XYZMODEM bool command/: config CMD_XYZMODEM bool "bla" select XYZMODEM help ... Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
