On Fri, Oct 12, 2012 at 11:30:40AM +0200, Teresa Gamez wrote: > Am 12.10.2012 09:58, schrieb Sascha Hauer: > > Hello Sascha, > > >Nice work. As Jean Christophe already mentioned, it would be nice to > >skip the base address. That would mean to have a omap_add_mmc() function > >like above in an omap generic place and then: > > > >static inline struct device_d omap<x>_add_mmc<y>(void *pdata) > >{ > > omap_add_mmc(OMAPx_MMCy_BASE, pdata); > >} > > > >in omap3/4 specific include files. > > > >Let me know if you want to work on this, otherwise I'm also happy to > >apply this one as it's already a step forward. > I will change it as you suggested. > I would base my rework on next so I can apply the changes also on > the archosg9 board. Ok, thanks Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox