Hi Teresa,
On Thu, Oct 11, 2012 at 09:25:34AM +0200, Teresa Gámez wrote:
> Created wrapper to add omap devices.
>
> Signed-off-by: Teresa Gámez <t.gamez@xxxxxxxxx>
> ---
> +
> +struct device_d *omap_add_mmc(resource_size_t base, void *pdata)
> +{
> + return omap_add_device("omap-hsmmc", base, SZ_4K, pdata);
> +}
Nice work. As Jean Christophe already mentioned, it would be nice to
skip the base address. That would mean to have a omap_add_mmc() function
like above in an omap generic place and then:
static inline struct device_d omap<x>_add_mmc<y>(void *pdata)
{
omap_add_mmc(OMAPx_MMCy_BASE, pdata);
}
in omap3/4 specific include files.
Let me know if you want to work on this, otherwise I'm also happy to
apply this one as it's already a step forward.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
