On Wed, Sep 26, 2012 at 12:59:47AM +0200, vj wrote: > Hello, > A this is my first contribution, so I'm basically requesting for comments. > > The attached patch adds support for Archos G9 tablet wich uses an OMAP4460 cpu. > The tablet by default only boots from internal flash, so to test > barebox on it a hardware tweak is required: change the sys_boot > configuration. Once done the tablet can be booted with the following > command: > A sudo scripts/usbboot <first_stage> <rootfs> > > The patch contains > A 1.- specific changes for OMAP4460 > A 2.- support for usb-booting > A 3.- support for console on usb > A 4.- support for file transfer through usb > A 5.- some minor bug fixes > A 6.- adds support for archosg9 board > > A question I have is what does omap_vector_init do? > It breaks usb-booting. > An improvement to be done would be to split the file > "scripts/usbboot.c" into a header and two c files, but the Makefile > framework seemed to me to do not allow that. > > In any case the patch should be tested with other boards to check it > does not breaks something. This is very interesting stuff indeed. Now that I read through the series I can say that the biggest single problem with it is the missing context of filenames and function names. All OMAP specific stuff should have a omap_ or omap4_ prefix. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
