Re: [PATCH 3/4] mtd nand: add mxs-nand driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Marek,

Sorry to bother you with barebox patches, I realized after the fact
that the Cc list gets expanded with the Signed-off-bys. Anyway
congratulations for your first barebox patch ;)

On Fri, Jun 08, 2012 at 05:06:13PM +0200, Marek Vasut wrote:
> Dear Sascha Hauer,
> 
> > From: Wolfram Sang <w.sang@xxxxxxxxxxxxxx>
> > 
> > Based on the U-Boot version. Changed to kernel style register layout, added
> > MX23 support (WIP!), made MMU aware and adapted to barebox.
> 
> Can you split the changes so it's not such a block of code, hard to review ?

Sorry, I don't have the history of this patches.

> Possibly to "kernel style register layout" (which I believe is stupid anyway, 
> using struct based access is less error prone and more clear),

That's your mileage, others may vary.

>  "mx23 support" 
> and "mmu awareness" (whatever that is).

Basically cache flushing/invalidating.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox


[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux