Re: [PATCH 3/4] mtd nand: add mxs-nand driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dear Sascha Hauer,

> From: Wolfram Sang <w.sang@xxxxxxxxxxxxxx>
> 
> Based on the U-Boot version. Changed to kernel style register layout, added
> MX23 support (WIP!), made MMU aware and adapted to barebox.

Can you split the changes so it's not such a block of code, hard to review ? 
Possibly to "kernel style register layout" (which I believe is stupid anyway, 
using struct based access is less error prone and more clear), "mx23 support" 
and "mmu awareness" (whatever that is).

> Signed-off-by: Marek Vasut <marek.vasut@xxxxxxxxx>
> Signed-off-by: Wolfram Sang <w.sang@xxxxxxxxxxxxxx>
> Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>

Best regards,
Marek Vasut

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox


[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux