Hi Esben,
On Mon, Mar 26, 2012 at 07:29:04PM +0200, esben.haabendal@xxxxxxxxx wrote:
> From: Esben Haabendal <esben.haabendal@xxxxxxxxx>
>
> There was no check for BE, so any BITKEEPER(1) iomux configurations
> were not being applied.
>
> Signed-off-by: Esben Haabendal <esben.haabendal@xxxxxxxxx>
> ---
> arch/arm/mach-mxs/iomux-imx.c | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-mxs/iomux-imx.c b/arch/arm/mach-mxs/iomux-imx.c
> index 3161a5d..6bcde03 100644
> --- a/arch/arm/mach-mxs/iomux-imx.c
> +++ b/arch/arm/mach-mxs/iomux-imx.c
> @@ -128,6 +128,12 @@ void imx_gpio_mode(uint32_t m)
> (GET_PULLUP(m) == 1 ? BIT_SET : BIT_CLR));
> }
>
> + if (BK_PRESENT(m)) {
> + reg_offset = calc_pullup_reg(gpio_pin);
> + writel(0x1 << (gpio_pin % 32), IMX_IOMUXC_BASE + reg_offset +
> + (GET_BITKEEPER(m) == 1 ? BIT_SET : BIT_CLR));
> + }
I just noticed this breaks i.MX23 support:
arch/arm/mach-mxs/iomux-imx.c: In function 'imx_gpio_mode':
arch/arm/mach-mxs/iomux-imx.c:131:2: warning: implicit declaration of function 'BK_PRESENT' [-Wimplicit-function-declaration]
arch/arm/mach-mxs/iomux-imx.c:133:3: warning: implicit declaration of function 'GET_BITKEEPER' [-Wimplicit-function-declaration]
arch/arm/mach-mxs/built-in.o: In function `imx_gpio_mode':
/home/sha/dude/barebox/barebox/arch/arm/mach-mxs/iomux-imx.c:131: undefined reference to `BK_PRESENT'
/home/sha/dude/barebox/barebox/arch/arm/mach-mxs/iomux-imx.c:133: undefined reference to `GET_BITKEEPER'
make: *** [barebox] Error 1
Care to send a fix for this? You can reproduce this using the
chumby_defconfig.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
