> -----Original Message----- > From: Sascha Hauer [mailto:s.hauer@xxxxxxxxxxxxxx] > Sent: Friday, February 10, 2012 5:54 PM > To: Premi, Sanjeev > Cc: barebox@xxxxxxxxxxxxxxxxxxx > Subject: Re: [RFC] omap3evm: Set preliminary environment > > On Thu, Feb 09, 2012 at 11:54:28PM +0530, Sanjeev Premi wrote: > > This is still work-in-progress, but wanted to > > share them early for any feedback. > > > > Signed-off-by: Sanjeev Premi <premi@xxxxxx> > > --- > > I have made offline edits on these scripts before making > > this patch. There is a possibility of run-time failure. > > > > You will also observe many TODOs. Hope to get them sorted > > tomorrow - for a patch worthy of applying on the tree. > > You are rewriting what we already have in form of the generic > environment. You shouldn't do this, we've been there before. > Before there was the generic environment every board had its > own set of environment scripts. This resulted in tons of > board specific scripts in slightly different states. Agree. I didn't want duplication - but was swayed by "FIXME"s the barebox/defaultenv and scripts in some of the boards that I saw. It is possible to override selective variables? e.g. machine=FIXME bootargs="console=ttyFIXME,115200" kernel_part=disk0.2 Is there an example to refer? ~sanjev > > Sascha > > -- > Pengutronix e.K. | > | > Industrial Linux Solutions | > http://www.pengutronix.de/ | > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: > +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: > +49-5121-206917-5555 | > _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
