On Tue, 7 Feb 2012, Sascha Hauer wrote: > On Mon, Feb 06, 2012 at 10:57:22AM -0500, Robert P. J. Day wrote: ... snip ... > > i tried it and it seems to work fine although the aesthetics in > > "make menuconfig" is a bit strange WRT order: > > > > (Texas Instrument's Beagle) Board info > > Select OMAP board (Texas Instrument's Beagle Board) ---> > > > > but that could be fixed just by moving the BOARDINFO entry below the > > board choice in that file. > > > > was this already discussed and rejected once upon a time? it's not > > a big deal but it has the value of being moderately informative. > > It hasn't been discussed before. It's mostly the way it is because I > did it that way without much thinking. The change you suggest has > one drawback. Consider you do a make menuconfig and change the > board. Currently BOARDINFO correctly changes to the new board, but > if we prompt the user for BOARDINFO the board string will still have > the name of the old board. i'd noticed that but didn't know if there was any way to resolve it easily. > I think the board name does not have to come from Kconfig anyway. > How about keeping things in Kconfig how they are but instead of > using CONFIG_BOARDINFO directly we could use a string. This string > defaults to CONFIG_BOARDINFO but can be overwritten by board code by > calling a set_boardinfo(const char *) function. For new boards we > could use this exclusively and maybe convert the existing boards > over to it. i didn't want to make a big deal of this, i figured if it was something sufficiently simple, it would be useful. rday -- ======================================================================== Robert P. J. Day Ottawa, Ontario, CANADA http://crashcourse.ca Twitter: http://twitter.com/rpjday LinkedIn: http://ca.linkedin.com/in/rpjday ======================================================================== _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox