> -----Original Message----- > From: Belisko Marek [mailto:marek.belisko@xxxxxxxxx] > Sent: Wednesday, February 01, 2012 4:40 PM > To: Premi, Sanjeev > Cc: barebox@xxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH 1/2] omap: Remove OMAP_GPMC prompt and usage. > > On Wed, Feb 1, 2012 at 12:05 PM, Premi, Sanjeev <premi@xxxxxx> wrote: > > > >> -----Original Message----- > >> From: Belisko Marek [mailto:marek.belisko@xxxxxxxxx] > >> Sent: Wednesday, February 01, 2012 3:46 PM > >> To: Premi, Sanjeev > >> Cc: barebox@xxxxxxxxxxxxxxxxxxx > >> Subject: Re: [PATCH 1/2] omap: Remove OMAP_GPMC prompt and usage. > >> > >> On Wed, Feb 1, 2012 at 10:32 AM, Premi, Sanjeev > <premi@xxxxxx> wrote: > >> >> -----Original Message----- > >> >> From: barebox-bounces@xxxxxxxxxxxxxxxxxxx > >> >> [mailto:barebox-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of > >> >> Marek Belisko > >> >> Sent: Wednesday, February 01, 2012 2:21 AM > >> >> To: barebox@xxxxxxxxxxxxxxxxxxx > >> >> Cc: Marek Belisko > >> >> Subject: [PATCH 1/2] omap: Remove OMAP_GPMC prompt and usage. > >> >> > >> >> Build for omap platform by default. > >> >> > >> >> Signed-off-by: Marek Belisko <marek.belisko@xxxxxxxxxxxxxxx> > >> >> --- > >> >> arch/arm/boards/beagle/board.c | 4 ++-- > >> >> arch/arm/boards/omap343xdsp/board.c | 2 -- > >> >> arch/arm/boards/omap3evm/board.c | 3 +-- > >> >> arch/arm/boards/phycard-a-l1/pca-a-l1.c | 3 --- > >> >> arch/arm/configs/panda_xload_defconfig | 1 - > >> >> arch/arm/configs/phycard_a_l1_defconfig | 1 - > >> >> arch/arm/mach-omap/Kconfig | 10 ---------- > >> >> arch/arm/mach-omap/Makefile | 3 +-- > >> >> drivers/mtd/nand/Kconfig | 1 - > >> >> 9 files changed, 4 insertions(+), 24 deletions(-) > >> >> > > > > [snip]...[snip] > > > >> > The config option helps in reducing the extra code being > built into > >> > the "xload" configurations - where the size matters. > >> > > >> > Instead of making this change, I suggest you add this in > >> the defconfig > >> > for pandaboard: > >> > CONFIG_OMAP_GPMC=y > >> > > >> > It is much smaller change. > >> GPMC is common for omap platform so I don't see a benefit > to add user > >> possibility to disable it and > >> then make his board un-bootable. Solution was proposed by Sascha : > >> http://www.spinics.net/lists/u-boot-v2/msg05897.html > > > > I missed this discussion, but if in the early boot stages we aren't > > concerned about the devices on GPMC, then we shouldn't be > initializing it. > > > > I don't have code in front of me, so can't say whether this is the > > case for xload configurations today - but I am assuming this was the > > original intent of having this option. > > > > On OMAP3EVM, GPMC needs to be configured only if NAND and > Ethernet are > > used. Else, the init can easily be skipped. > > > > In patch 2/2 you mentioned about the kernel crash. > > Can you share the crash log? > > (or point me to a post which already has it) > Crash is here: > http://www.spinics.net/lists/u-boot-v2/msg05887.html I can't be very certain without trying, but I suspect that the crash is due the BUG() in this snippet [function gpmc_mem_init]: /* Reserve all regions that has been set up by bootloader */ for (cs = 0; cs < GPMC_CS_NUM; cs++) { u32 base, size; if (!gpmc_cs_mem_enabled(cs)) continue; gpmc_cs_get_memconf(cs, &base, &size); if (gpmc_cs_insert_mem(cs, base, size) < 0) BUG(); } In barebox, gpmc_generic_init(0x00) is makes GPMC_CONFIG as 0x00 and sets GPMC_CONFIG7_i (i = 0 to 7) as 0x00 making CS0 "disabled" - which is enabled on reset for OMAP3 (expect same for OMAP4 as well). All other CS are "disabled" on reset. This disables CS0 as well, making gpmc_cs_mem_enabled(cs) return false. (May be expected for Pandaboard). If so, I still feel, the code could easily be left out from the xload configs. But if it has to included, 136 bytes from gpmc.o may not be as big penalty. ~sanjeev > > > > ~sanjeev > > > >> > >> > > >> > ~sanjeev > >> > > >> >> 1.7.5.4 > >> >> > >> >> > >> >> _______________________________________________ > >> >> barebox mailing list > >> >> barebox@xxxxxxxxxxxxxxxxxxx > >> >> http://lists.infradead.org/mailman/listinfo/barebox > >> >> > >> > >> regards, > >> > >> marek > >> > >> -- > >> as simple and primitive as possible > >> ------------------------------------------------- > >> Marek Belisko - OPEN-NANDRA > >> Freelance Developer > >> > >> Ruska Nova Ves 219 | Presov, 08005 Slovak Republic > >> Tel: +421 915 052 184 > >> skype: marekwhite > >> twitter: #opennandra > >> web: http://open-nandra.com > >> > > marek > > -- > as simple and primitive as possible > ------------------------------------------------- > Marek Belisko - OPEN-NANDRA > Freelance Developer > > Ruska Nova Ves 219 | Presov, 08005 Slovak Republic > Tel: +421 915 052 184 > skype: marekwhite > twitter: #opennandra > web: http://open-nandra.com > _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
