On Fri, Jan 27, 2012 at 05:07:04PM +0100, Robert Jarzmik wrote: > Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> writes: > > > On Thu, Jan 26, 2012 at 08:55:28PM +0100, Robert Jarzmik wrote: > >> Add PXA embedded pulse width modulator support. The PWM can > >> generate signals from 49.6kHz to 1.625MHz. > >> > >> Signed-off-by: Robert Jarzmik <robert.jarzmik@xxxxxxx> > >> --- > > > > [...] > > > >> + > >> + /* NOTE: the clock to PWM has to be enabled first > >> + * before writing to the registers > >> + */ > > > > Does this mean that pwm_enable() has to be called prior to pxm_config()? > Yes. > > > I think we should rather have a real pwm API. > So do I. > > > The following Kernel patch could be easily adopted and the overhead is > > acceptable I think. > Would you adapt it or do you want me to do it ? I just sent a patch, compile tested only. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
