On 10:25 Wed 04 Jan , Sascha Hauer wrote:
> On Tue, Jan 03, 2012 at 06:00:47AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > this will allow to always call poller_call even durring timeout
> > and still the case in getc
> >
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@xxxxxxxxxxxx>
> > ---
> > common/clock.c | 4 ++++
> > common/console.c | 2 --
> > 2 files changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/common/clock.c b/common/clock.c
> > index 79c06c8..f322db8 100644
> > --- a/common/clock.c
> > +++ b/common/clock.c
> > @@ -27,6 +27,7 @@
> > #include <common.h>
> > #include <asm-generic/div64.h>
> > #include <clock.h>
> > +#include <poller.h>
> >
> > static struct clocksource *current_clock;
> > static uint64_t time_ns;
> > @@ -139,6 +140,9 @@ uint32_t clocksource_hz2mult(uint32_t hz, uint32_t shift_constant)
> >
> > int is_timeout(uint64_t start_ns, uint64_t time_offset_ns)
> > {
> > + if (time_offset_ns >= 100 * USECOND)
> > + poller_call();
>
> Do we need this if() at all? I think not.
for small delay such as bitbanging i2c delay need to be constant
Best Regards,
J.
>
> Sascha
>
> > +
> > if ((int64_t)(start_ns + time_offset_ns - get_time_ns()) < 0)
> > return 1;
> > else
> > diff --git a/common/console.c b/common/console.c
> > index cab8689..88c4010 100644
> > --- a/common/console.c
> > +++ b/common/console.c
> > @@ -225,8 +225,6 @@ int getc(void)
> > */
> > start = get_time_ns();
> > while (1) {
> > - poller_call();
> > -
> > if (tstc_raw()) {
> > kfifo_putc(console_input_buffer, getc_raw());
> >
> > --
> > 1.7.7
> >
> >
> > _______________________________________________
> > barebox mailing list
> > barebox@xxxxxxxxxxxxxxxxxxx
> > http://lists.infradead.org/mailman/listinfo/barebox
> >
>
> --
> Pengutronix e.K. | |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
