> -----Original Message----- > From: Premi, Sanjeev > Sent: Wednesday, October 12, 2011 4:34 PM > To: barebox@xxxxxxxxxxxxxxxxxxx > Cc: Premi, Sanjeev > Subject: [PATCH v3] omap: Unify run_shell() in xload configuration > > Currently, there are multiple definitions of run_shell() > for each board that can be build in "xload" configuration. > Now there is only one function used by all boards. > > The functions defined in xload.c are used only when "xload" > configuration used; but it gets compiled unconditionally. > This has been fixed as well. > > Signed-off-by: Sanjeev Premi <premi@xxxxxx> > --- > > Change in v3: > Added function omap_bootsrc() to replace the #ifdef > around the switch-case. > > Change in v2: > Fixed the typo in the subject s/iomap/omap/ > ...observed when mail reached my inbox :( > > Only build tested with these commands: > make distclean ; make omap3530_beagle_defconfig ; make ; > make distclean ; make omap3530_beagle_xload_defconfig ; make ; > make distclean ; make panda_xload_defconfig ; make ; > make distclean ; make panda_defconfig ; make ; > make distclean ; make pcm049_defconfig ; make ; > make distclean ; make pcm049_xload_defconfig ; make ; > > > arch/arm/boards/omap/board-beagle.c | 31 -------------------------- > arch/arm/boards/panda/board.c | 19 ---------------- > arch/arm/boards/pcm049/board.c | 30 ------------------------- > arch/arm/mach-omap/Makefile | 3 +- > arch/arm/mach-omap/xload.c | 41 > +++++++++++++++++++++++++++++++++++ > 5 files changed, 43 insertions(+), 81 deletions(-) > Jean-Christophe, Just wanted to check if this patch takes care of your comment[1]. [1] http://lists.infradead.org/pipermail/barebox/2011-October/004752.html ~sanjeev [snip]...[snip] _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox