On Thu, Sep 15, 2011 at 03:27:36PM +0400, Paul Fertser wrote: > This guards for the cases where the initial offset or byte count is > not aligned with regard to erase block size, thus making it impossible > for erase to do any harm to the nearby sectors. I'm unsure about this one. The other flash drivers allow to erase areas which are not eraseblock aligned. Maybe we should instead add a cdev->erasesize field. Then we can add this check in the generic code and fix this for all drivers. (I know this won't work for some nor flashes which have eraseblocks of different size, but this special case could still be checked in the driver) Sascha > > Signed-off-by: Paul Fertser <fercerpav@xxxxxxxxx> > --- > drivers/nor/m25p80.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/drivers/nor/m25p80.c b/drivers/nor/m25p80.c > index e6fe75e..6f650a5 100644 > --- a/drivers/nor/m25p80.c > +++ b/drivers/nor/m25p80.c > @@ -206,7 +206,9 @@ static ssize_t m25p80_erase(struct cdev *cdev, size_t count, unsigned long offse > __func__, "at", (long long)offset, (long long)count); > > /* sanity checks */ > - if (offset + count > flash->size) > + if ((offset + count > flash->size) || > + (offset % flash->erasesize) || > + ((offset+count) % flash->erasesize)) > return -EINVAL; > > addr = offset; > -- > 1.7.2.3 > > > _______________________________________________ > barebox mailing list > barebox@xxxxxxxxxxxxxxxxxxx > http://lists.infradead.org/mailman/listinfo/barebox > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
