On Mon, Nov 15, 2010 at 11:04:52AM +0100, Juergen Beisert wrote:
> Sascha Hauer wrote:
> > [...]
> > > + fb_dev->priv = cdev; /* pointer forward */
> > > + cdev->dev = fb_dev; /* pointer backward */
> > > +
> > > + cdev->ops = &fb_ops;
> > > + cdev->name = asprintf("fb%d", id);
> > > +
> > > + cdev->size = fb_dev->size; /* use the default if any */
> > > + cdev->priv = info;
> > > +
> > > + info->host = host;
> > > + info->fb_dev = fb_dev;
> > > +
> > > + /* setup defaults */
> > > + if (host->bits_per_pixel != 0)
> > > + info->bits_per_pixel = host->bits_per_pixel;
> > > + else
> > > + info->bits_per_pixel = 16; /* means RGB565 */
> >
> > No, this does not mean RGB565. It could also mean BGR or even something
> > else.
>
> You are right. But currently it means exactly what I wrote. All drivers
> currently using RGB565 for 16 bpp. To make it as you stated, we need more
> information about the bits per colour and their layout. Currently the
> graphics drivers do it in their own way. No way to intervent from the
> platform file.
No, the drivers are free to pass an arbitrary layout to the framework
using fb_bitfields. So you can't state in the framework that 16bit is
RGB565.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
