The do_devinfo_subtree() function is only used if devinfo is compiled in, so put it under the same ifdef. This avoids the following warning when built with allnoconfig: lib/driver.c:247: warning: 'do_devinfo_subtree' defined but not used Signed-off-by: Robert Schwebel <r.schwebel@xxxxxxxxxxxxxx> --- lib/driver.c | 42 +++++++++++++++++++++--------------------- 1 files changed, 21 insertions(+), 21 deletions(-) diff --git a/lib/driver.c b/lib/driver.c index 66d8fee..a05e7e3 100644 --- a/lib/driver.c +++ b/lib/driver.c @@ -244,6 +244,27 @@ int dummy_probe(struct device_d *dev) } EXPORT_SYMBOL(dummy_probe); +const char *dev_id(const struct device_d *dev) +{ + static char buf[sizeof(unsigned long) * 2]; + + sprintf(buf, FORMAT_DRIVER_MANE_ID, dev->name, dev->id); + + return buf; +} + +void devices_shutdown(void) +{ + struct device_d *dev; + + list_for_each_entry(dev, &active, active) { + if (dev->driver->remove) + dev->driver->remove(dev); + } +} + +#ifdef CONFIG_CMD_DEVINFO + static int do_devinfo_subtree(struct device_d *dev, int depth, char edge) { struct device_d *child; @@ -276,27 +297,6 @@ static int do_devinfo_subtree(struct device_d *dev, int depth, char edge) return 0; } -const char *dev_id(const struct device_d *dev) -{ - static char buf[sizeof(unsigned long) * 2]; - - sprintf(buf, FORMAT_DRIVER_MANE_ID, dev->name, dev->id); - - return buf; -} - -void devices_shutdown(void) -{ - struct device_d *dev; - - list_for_each_entry(dev, &active, active) { - if (dev->driver->remove) - dev->driver->remove(dev); - } -} - -#ifdef CONFIG_CMD_DEVINFO - static int do_devinfo(struct command *cmdtp, int argc, char *argv[]) { struct device_d *dev; -- 1.7.2.3 _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox