Hi, sorry I haven't had time to look into this yet. I think the suggested change is ok. With the other variables in that file they might exists or not, but these ones should always be present so there's no need for cmake to run any check extra check logic. Let me know if you still have issues and I'll try to find some time to do fixes. Thanks, Tuomo On Fri, Sep 28, 2018 at 11:26 AM Martin Kepplinger <martink at posteo.de> wrote: > > Am 27.09.2018 09:22 schrieb Martin Kepplinger: > > hi Tuomo, > > > > When I change the top-level CMakeLists.txt's version variable so that > > one is zero, like: > > set(LIBTS_VERSION_REVISION 0) > > I get: > > > > [ 19%] Building C object src/CMakeFiles/tslib.dir/ts_version.c.o > > /home/martin/dev/tslib/src/ts_version.c: In function ?ts_libversion?: > > /home/martin/dev/tslib/src/ts_version.c:49:10: error: > > ?LIBTS_VERSION_REVISION? undeclared (first use in this function) > > patch = LIBTS_VERSION_REVISION; > > > > > > Could you look into this? Especially this variable must be possible to > > be 0. > > > > After playing around with it a little I came up with this, which seems > to build correctly: > https://github.com/kergoth/tslib/commit/1d125b6b4fda0542696342b1da0b2efe66a93ab4 > > Does this change make sense to you? > > thanks > > martin >
