On 9/6/22 10:45 AM, Dmitry Bogdanov wrote:
> +
> +static ssize_t core_tpg_rtpi_store(struct config_item *item,
> + const char *page, size_t count)
> +{
> + struct se_portal_group *se_tpg = attrib_to_tpg(item);
> + struct se_portal_group *tpg;
> + bool rtpi_changed = false;
> + u16 val;
> + int ret;
> +
> + ret = kstrtou16(page, 0, &val);
> + if (ret < 0)
> + return ret;
> + if (val == 0)
> + return -EINVAL;
> +
> + /* RTPI shouldn't conflict with values of existing ports */
> + spin_lock(&g_tpg_lock);
> +
> + list_for_each_entry(tpg, &g_tpg_list, tpg_list) {
> + if (se_tpg != tpg && val == tpg->tpg_rtpi) {
> + spin_unlock(&g_tpg_lock);
> + pr_err("TARGET_CORE[%s]->TPG[%u] - RTPI %#x conflicts with TARGET_CORE[%s]->TPG[%u]\n",
> + se_tpg->se_tpg_tfo->fabric_name,
> + se_tpg->se_tpg_tfo->tpg_get_tag(tpg),
> + val,
> + tpg->se_tpg_tfo->fabric_name,
> + tpg->se_tpg_tfo->tpg_get_tag(tpg));
> + return -EINVAL;
> + }
> + }
> +
> + if (se_tpg->tpg_rtpi != val) {
> + se_tpg->tpg_rtpi = val;
> + rtpi_changed = true;
> + }
> + spin_unlock(&g_tpg_lock);
> +
> + if (rtpi_changed)
> + core_tpg_ua(se_tpg, 0x3f, ASCQ_3FH_INQUIRY_DATA_HAS_CHANGED);
> + ret = count;
> +
> + return ret;
Just return count.
