Re: [PATCH 3/8] scsi: don't memset the entire scsi_cmnd in scsi_init_command

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 24/02/2022 16:27, Christoph Hellwig wrote:
On Thu, Feb 24, 2022 at 08:28:48AM +0000, John Garry wrote:
+	if (!blk_rq_is_passthrough(rq) && !(cmd->flags & SCMD_INITIALIZED)) {
+		cmd->flags |= SCMD_INITIALIZED;
Maybe I'm being dozy, but isn't this being cleared below *
with below you mean the

	cmd->flags &= SCMD_PRESERVED_FLAGS;

?  No, that doen't clear the flag, but all the others.

Yeah, I was wrong as SCMD_INITIALIZED is included in (actually same as) SCMD_PRESERVED_FLAGS mask.

Sorry for the noise.

Cheers,
John



[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux