Re: [PATCH 3/8] scsi: don't memset the entire scsi_cmnd in scsi_init_command

[Christoph Hellwig <hch@xxxxxx>]

On Thu, Feb 24, 2022 at 08:28:48AM +0000, John Garry wrote:
>> +	if (!blk_rq_is_passthrough(rq) && !(cmd->flags & SCMD_INITIALIZED)) {
>> +		cmd->flags |= SCMD_INITIALIZED;
>
> Maybe I'm being dozy, but isn't this being cleared below *

with below you mean the

	cmd->flags &= SCMD_PRESERVED_FLAGS;

?  No, that doen't clear the flag, but all the others.