Re: [PATCH] target/file: don't zero iter before iov_iter_bvec

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Pavel Begunkov <asml.silence@xxxxxxxxx>
Subject: Re: [PATCH] target/file: don't zero iter before iov_iter_bvec
From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Date: Wed, 13 Jan 2021 00:34:03 -0500
Cc: "Martin K . Petersen" <martin.petersen@xxxxxxxxxx>, linux-scsi@xxxxxxxxxxxxxxx, target-devel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <34cd22d6cec046e3adf402accb1453cc255b9042.1610207523.git.asml.silence@gmail.com> (Pavel Begunkov's message of "Sat, 9 Jan 2021 15:53:27 +0000")
Organization: Oracle Corporation
References: <34cd22d6cec046e3adf402accb1453cc255b9042.1610207523.git.asml.silence@gmail.com>

Pavel,

> iov_iter_bvec() initialises iterators well, no need to pre-zero it
> beforehand as done in fd_execute_rw_aio(). Compilers can't optimise it
> out and generate extra code for that (confirmed with assembly).

Applied to 5.12/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

References:
- [PATCH] target/file: don't zero iter before iov_iter_bvec
  - From: Pavel Begunkov

Prev by Date: [PATCH] scsi: target: tcmu: Fix use-after-free of se_cmd->priv
Next by Date: Re: [PATCH] scsi: target: tcmu: Fix use-after-free of se_cmd->priv
Previous by thread: Re: [PATCH] target/file: don't zero iter before iov_iter_bvec
Next by thread: Re: [PATCH] target/file: don't zero iter before iov_iter_bvec
Index(es):
- Date
- Thread

[Index of Archives] [Linux SCSI] [Kernel Newbies] [Linux SCSI Target Infrastructure] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Linux IIO] [Device Mapper]

Powered by Linux