Re: [PATCH] target/file: don't zero iter before iov_iter_bvec

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Pavel Begunkov <asml.silence@xxxxxxxxx>, "Martin K . Petersen" <martin.petersen@xxxxxxxxxx>
Subject: Re: [PATCH] target/file: don't zero iter before iov_iter_bvec
From: Bart Van Assche <bvanassche@xxxxxxx>
Date: Sun, 10 Jan 2021 18:49:11 -0800
Cc: linux-scsi@xxxxxxxxxxxxxxx, target-devel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <34cd22d6cec046e3adf402accb1453cc255b9042.1610207523.git.asml.silence@gmail.com>
References: <34cd22d6cec046e3adf402accb1453cc255b9042.1610207523.git.asml.silence@gmail.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0

On 1/9/21 7:53 AM, Pavel Begunkov wrote:
> iov_iter_bvec() initialises iterators well, no need to pre-zero it
> beforehand as done in fd_execute_rw_aio(). Compilers can't optimise it
> out and generate extra code for that (confirmed with assembly).

Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>

References:
- [PATCH] target/file: don't zero iter before iov_iter_bvec
  - From: Pavel Begunkov

Prev by Date: Re: [PATCH] target/file: don't zero iter before iov_iter_bvec
Next by Date: Re: [PATCH v3 1/7] splice: don't generate zero-len segement bvecs
Previous by thread: Re: [PATCH] target/file: don't zero iter before iov_iter_bvec
Next by thread: Re: [PATCH] target/file: don't zero iter before iov_iter_bvec
Index(es):
- Date
- Thread

[Index of Archives] [Linux SCSI] [Kernel Newbies] [Linux SCSI Target Infrastructure] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Linux IIO] [Device Mapper]

Powered by Linux