Re: [RFC PATCH] target: add emulate_pr backstore attr to toggle PR support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/21/2018 10:26 AM, David Disseldorp wrote:
> On Mon, 4 Jun 2018 12:13:22 -0500, Mike Christie wrote:
> 
>>> AFAICT, targetcli (via rtslib-fb) only makes use of the
>>> res_aptpl_metadata path. I'm not aware of any other consumers, so happy
>>> to go with whatever the community preference is here.
>>>   
>>
>> I just seems odd to have a file use 2 different formats for no reason
>> except there were 2 different people coding it.
> 
> It's already a bit inconsistent, in that res_holder_show() returns human
> readable strings and res_type_show() opts for enum type strings. I've
> changed both to use "SPC_RESERVATIONS_DISABLED" for the disabled case
> for now.
> 

I was only asking that we at least have the same format within a file,
so we do not have messes like the backend info file.

--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux