Hi all,
This is a second patchset which uses ib_client API in order to wrap
ib_device with a specific ULP device, which is created on add() callback
and destroyed on remove(). Patches change initiator and target sides
for NVMEoRDMA and ISER. Changes do not bring anything in terms of LoC
but extra mutexes and lists are vanished, since ib_client API does
required locking internally.
Also would be nice to avoid refcounting and synchronization in ISER
case, but ULP ib_clients remove() callback is called before cma_client,
thus ULP device should be alive till last reference put (NVMe queues
explicit delete works with workqueue flush, which guarantees us that
nvme_dev_dev_put() puts last reference in remove() callback).
The following are the minor fixes since previous RFC:
NVMe:
o Keep IB_DEVICE_MEM_MGT_EXTENSIONS check in nvme_rdma_alloc_device().
o No WARN_ON if nvme[t]_rdma_alloc_device() failed, just a log output.
iSER[t]:
o Rename ib_client.name from "iser[t]_rdma_ib" to "iser[t]_ib_client".
o Move all refcount changes to separate patches.
Roman Pen (8):
nvme-rdma: use ib_client API to wrap ib_device
nvmet-rdma: wrap raw kref_get/put() with corresponding helpers
nvmet-rdma: use ib_client API to wrap ib_device
IB/iser: use refcount_t instead of just a raw integer
IB/iser: use ib_client API to wrap ib_device
IB/isert: embed mutex inside isert_device structure
IB/isert: use refcount_t instead of just a raw integer
IB/isert: use ib_client API to wrap ib_device
drivers/infiniband/ulp/iser/iscsi_iser.c | 21 ++++--
drivers/infiniband/ulp/iser/iscsi_iser.h | 14 ++--
drivers/infiniband/ulp/iser/iser_verbs.c | 73 +++++++++++++--------
drivers/infiniband/ulp/isert/ib_isert.c | 109 ++++++++++++++++++++-----------
drivers/infiniband/ulp/isert/ib_isert.h | 4 +-
drivers/nvme/host/rdma.c | 82 +++++++++++------------
drivers/nvme/target/rdma.c | 87 ++++++++++++------------
7 files changed, 227 insertions(+), 163 deletions(-)
Signed-off-by: Roman Pen <roman.penyaev@xxxxxxxxxxxxxxx>
Cc: Christoph Hellwig <hch@xxxxxx>
Cc: Steve Wise <swise@xxxxxxxxxxxxxxxxxxxxx>
Cc: Bart Van Assche <bart.vanassche@xxxxxxxxxxx>
Cc: Sagi Grimberg <sagi@xxxxxxxxxxx>
Cc: Doug Ledford <dledford@xxxxxxxxxx>
Cc: target-devel@xxxxxxxxxxxxxxx
Cc: linux-nvme@xxxxxxxxxxxxxxxxxxx
--
2.13.1
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
