On Thu, 22 Feb 2018 16:56:00 +0300, Dan Carpenter wrote: ... > Calling crypto_free_shash(NULL) is actually fine. It doesn't > dereference the parameter, it just does pointer math on it in > crypto_shash_tfm() and returns if it's NULL in crypto_destroy_tfm(). Bleh, you're right. I read the crypto_shash_tfm() code path incorrectly. -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html