[cc list trimmed] On Wed, 21 Feb 2018 17:45:35 +0100, SF Markus Elfring wrote: ... > One of these update suggestions resulted in the commit “target: avoid NULL > dereference in CHAP auth error path” which is considered for integration > into Linux stable versions now. > https://patchwork.kernel.org/patch/10110459/ > https://lkml.kernel.org/r/<20171213172230.12767-1-ddiss@xxxxxxx> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/target/iscsi/iscsi_target_auth.c?id=ce512d79d0466a604793addb6b769d12ee326822 You're 1/8 patch had an actual bug fix hidden amongst the style churn. I don't see any such fixes in the other patches. > Now I am curious if more remaining change possibilities can be picked up > from this patch series. > > * Would you like to improve any more implementation details? > > * Do you need additional explanations for further benefits? My opinion from https://www.spinics.net/lists/target-devel/msg16342.html hasn't changed. FWIW, I'd prefer to see LIO adopt a policy similar to: https://btrfs.wiki.kernel.org/index.php/Developer%27s_FAQ#How_not_to_start Cheers, David -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html