On Thu, 2017-06-22 at 14:14 -0700, Bart Van Assche wrote: > On 06/08/17 22:34, Nicholas A. Bellinger wrote: > > On Tue, 2017-06-06 at 18:42 +0000, Bart Van Assche wrote: > >> On Fri, 2017-06-02 at 21:19 -0700, Nicholas A. Bellinger wrote: > >>> Can I have a look at the full debug with the missing > >>> srpt_close_sessions() messages to see if it's being called twice for the > >>> same se_session, and the code changes against v4.12-rc3 you're testing > >>> with that account for the ~50 lines offset..? > >> > >> Hello Nic, > >> > >> I should have mentioned that I had also merged my branch with pending ib_srpt > >> patches in the kernel tree that I used in my test. Since these patches are > >> almost six months old, have not caused trouble before and are not related to > >> session shutdown I don't think these patches are related to this crash. Anyway, > >> I have attached these patches to this e-mail. > >> > >> It's probably easier for you if you can reproduce the reported crash yourself > >> instead of having to rely on me for testing? > > > > Heh, no. > > > > You are the ib_srpt maintainer, so I'm going to rely on you exactly for > > that. :) > > Please do not expect that I will do that. Anyone (you in this case) who > wants to change something in the target core is responsible for making > sure that such a change does not break any existing target driver. > That is unfortunate. However, keep in mind this is a regression, so it would at least be nice if you would take to time to figure out why a patch that doesn't change actual logic is causing ib_srpt problems, as it might be indicative of a deeper issue. In any event, I'll drop this patch for -rc1 and just add a separate function specific to se_node_acl->queue_depth change that doesn't effect any other code. Thanks for the heads up. -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
