On Wed, 2017-06-21 at 13:20 -0500, Mike Christie wrote: > On 06/21/2017 01:13 PM, Bart Van Assche wrote: > > On Fri, 2017-06-16 at 16:47 -0500, Mike Christie wrote: > > > In the next patches we will add tcmu netlink support that allows > > > userspace to send commands to target_core_user. To execute operations > > > on a se_device/tcmu_dev we need to be able to look up a dev by any old > > > id. This patch replaces the se_device->dev_index with a idr created > > > id. > > > > > > The next patches will also remove the g_device_list and replace it with > > > the idr. > > > > Hello Mike, > > > > Although this patch looks fine to me I would appreciate it if all uses of > > scsi_get_new_index() would be converted into IDR. It doesn't make sense to > > me to use a single data structure (scsi_mib_index[]) to keep track of > > indexes of HBA instances, device instances and ACL instances. > > Just to make sure I understood you, do you mean have one idr for hba, > acl and dev index ids or one idr for acl, one for hba, etc? Hello Mike, What I meant is one idr for ACL, one for HBA and one for devices. That should match the current behavior of scsi_get_new_index(). Bart.-- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
