Re: [PATCH 03/11] target: use idr for se_device dev index

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2017-06-16 at 16:47 -0500, Mike Christie wrote:
> In the next patches we will add tcmu netlink support that allows
> userspace to send commands to target_core_user. To execute operations
> on a se_device/tcmu_dev we need to be able to look up a dev by any old
> id. This patch replaces the se_device->dev_index with a idr created
> id.
> 
> The next patches will also remove the g_device_list and replace it with
> the idr.

Hello Mike,

Although this patch looks fine to me I would appreciate it if all uses of
scsi_get_new_index() would be converted into IDR. It doesn't make sense to
me to use a single data structure (scsi_mib_index[]) to keep track of
indexes of HBA instances, device instances and ACL instances.

Bart.--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux