Re: [PATCH 08/19] target: Use get_unaligned_be*() instead of open coding these functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2017-05-05 at 11:47 +0200, Christoph Hellwig wrote:
> >  static unsigned long long core_scsi3_extract_reservation_key(unsigned char *cdb)
> >  {
> 
> ...
> > +	return get_unaligned_be64(cdb);
> >  }
> 
> Please remove this wrapper, especially as the parameter name is
> rather confusing as inherited from the existing code.

Hello Christoph,

That sounds like a good idea to me. I will update this patch.

Bart.--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux