> static unsigned long long core_scsi3_extract_reservation_key(unsigned char *cdb) > { ... > + return get_unaligned_be64(cdb); > } Please remove this wrapper, especially as the parameter name is rather confusing as inherited from the existing code. Otherwise looks fine: Reviewed-by: Christoph Hellwig <hch@xxxxxx> -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html