On Mon, 2017-02-06 at 10:14 -0800, Christoph Hellwig wrote:
> > @@ -2538,16 +2537,6 @@ int transport_generic_free_cmd(struct se_cmd *cmd, int wait_for_tasks)
> > if (cmd->se_lun)
> > transport_lun_remove_cmd(cmd);
> > }
> > - /*
> > - * If the task has been internally aborted due to TMR ABORT_TASK
> > - * or LUN_RESET, target_core_tmr.c is responsible for performing
> > - * the remaining calls to target_put_sess_cmd(), and not the
> > - * callers of this function.
> > - */
> > - if (aborted) {
> > - pr_debug("Detected CMD_T_ABORTED for ITT: %llu\n", cmd->tag);
> > - wait_for_completion(&cmd->cmd_wait_comp);
> > - }
>
> Previously this waited for the command to be freed from the TMR code,
> which provided a synchronization point. I don't think it's useful,
> but it should be mentioned in the changelog.
The session shutdown code still waits until aborted commands have been freed
because it waits until the reference count for all commands associated with a
session has dropped to zero. Do you really want me to mention this explicitly
in the changelog?
Bart.--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
