On 12/16/2016 10:59 AM, Varun Prakash wrote:
> On Thu, Dec 15, 2016 at 09:11:09PM +0530, Bart Van Assche wrote:
>> On 12/11/2016 05:35 PM, Varun Prakash wrote:
>>> If iscsit_tpg_add_network_portal() fails then
>>> return error code instead of 0 to user space.
>>>
>>> If iscsi-target returns 0 then user space keeps
>>> on retrying same command infinitely, targetcli or
>>> echo hangs till command completes with non zero
>>> return value. In some cases it is possible that
>>> add network portal command never completes with
>>> success even after retrying multiple times,
>>> for example - cxgbit_setup_np() always returns
>>> -EINVAL if portal IP does not belong to Chelsio
>>> adapter interface.
>>
>> Hello Varun,
>>
>> This patch looks fine to me. Since you posted it as an RFC does this
>> mean that you are not completely confident that this patch is right?
>
> Thanks for reviewing, I am completely confident that this
> patch is correct and I tested it before posting.
Hello Varun,
I have queued your patch for v4.10 and also added the following to your
patch:
[ bvanassche: Added Fixes: and Cc: stable tags ]
Fixes: commit d4b3fa4b0881 ("iscsi-target: Make iscsi_tpg_np driver
show/store use generic code")
Cc: <stable@xxxxxxxxxxxxxxx>
Bart.
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
