On Tue, Mar 08, 2016 at 11:33:43AM -0800, Bart Van Assche wrote: > My preference is to handle the "success" case first as in the original code: > > - if (!IS_ERR(qp)) > - __ib_insert_xrcd_qp(qp_init_attr->xrcd, real_qp); > - else > - real_qp->device->destroy_qp(real_qp); > > Even if this does not get addressed: > > Reviewed-by: Bart Van Assche <bart.vanassche@xxxxxxxxxxx> I don't really care either way, so I've changed this. -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html