On 03/08/2016 10:16 AM, Christoph Hellwig wrote: > + if (IS_ERR(qp)) > + real_qp->device->destroy_qp(real_qp); > + else > + __ib_insert_xrcd_qp(qp_init_attr->xrcd, real_qp); > + return qp; > +} My preference is to handle the "success" case first as in the original code: - if (!IS_ERR(qp)) - __ib_insert_xrcd_qp(qp_init_attr->xrcd, real_qp); - else - real_qp->device->destroy_qp(real_qp); Even if this does not get addressed: Reviewed-by: Bart Van Assche <bart.vanassche@xxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
