On 11/23/2015 05:14 PM, Bart Van Assche wrote:
On 11/22/2015 07:31 AM, Christoph Hellwig wrote:
On Sun, Nov 22, 2015 at 05:26:28PM +0200, Sagi Grimberg wrote:
No. register_always=Y is already broken in 4.3, but
register_always=N is
now also broken in 4.4.
OK, I'm confused so please let me understand slowly :)
Your patch "ib_srp: initialize dma_length in srp_map_idb" solves
the register_always=Y dma_length = 0 WARN_ON() on 4.4-rc, does it solve
the data integrity errors too?
No, it doesn't.
This code path is specific to srp because all other ULPs guarantee
no-gaps...
Yes. Life would be simpler if we could just set the virt_boundary
on SRP, and Bart has indicated that he's willing to at least looks at
this for the next merge window.
Hello Christoph,
Tomorrow I will try to reproduce this behavior on my test setup. I
prepared a setup with kernel v4.4-rc2 and on which the SRP initiator and
target are running on the same server. Tomorrow I will install xfstests
and see whether these tests pass fine against an XFS filesystem.
(replying to my own e-mail)
I can reproduce this behavior with both LIO and SCST. I have modified
initiator and target code such that the target appends a data CRC at the
end of the SRP_RSP IU and such that the initiator checks that CRC. A CRC
mismatch was reported for the following SG-list by the initiator:
scsi host10: srp_check_crc: bufflen 1024; resid 0; sg-list len 2; dir
DMA_TO_DEVICE; CRC mismatch (0x7916620b <> 0xde97b796); sg-list:
[0] ffff880407378348 len 512
[1] ffff880407378000 len 512
I will check the memory registration code next.
Bart.
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
