This patchset adds remote invalidation support to iser initiator and
target. The support negotiation for this feature is based on IBTA
annex 12 "Support for iSCSI Extensions for RDMA" carried in rdma_cm
private data.
Remote invalidation allows a peer host to invalidate a remote key
as part of a SEND operation. This feature allows a host to avoid
invalidating an rkey locally. By supporting this feature iser initiator
can save extra latency and processing time yielded by invalidating
the memory key locally.
The initiator feature support is dependent on:
- fastreg is used (not FMR)
- always_register=Y
In this case the initiator will expose support for remote invalidation,
however it will not blindly rely on the target to do so and will verify
that in the work completion information. The iser target now looks into
the iser header in the CM request and in case the initiator supports
remote invalidation it will respond it will use remote invalidation for
provided remote keys.
Thanks a lot to all the reviewers!
Changes from v0:
- Rebased on top of 4.4-rc2
- Removed iser_hello messages from the protocol header
- Avoided from further breaking the non-existent bidi support
- Fixed initiator remote invalidate support exposure only
for fastreg && iser_always_register
- Removed patch 2/10 as it's still under testing.
- Minor line-spacing nitpicks CR comments fixes.
- Added a FIXME comment to declare our debt to Or and Jason
on the awkward device->mr->rkey deref.
- Piggybacked another patch that reduces some iser code that
is now available by the ib_core (ib_sg_to_pages).
Code is available at:
git@xxxxxxxxxx:sagigrimberg/linux.git iser-remote-inv
Jenny Derzhavetz (5):
IB/iser: Don't register memory for all immediatedata writes
IB/iser: set intuitive values for mr_valid
iser-target: Declare correct flags when accepting a connection
iser-target: Support the remote invalidation exception
IB/iser: Support the remote invalidation exception
Roi Dayan (1):
IB/iser: Fix module init not cleaning up on error flow
Sagi Grimberg (4):
IB/iser: Reuse ib_sg_to_pages
iser: Have initiator and target to share protocol structures and
definitions
iser-target: Remove unused file iser_proto.h
IB/iser: Increment the rkey when registering and not when invalidating
drivers/infiniband/ulp/iser/iscsi_iser.c | 9 +-
drivers/infiniband/ulp/iser/iscsi_iser.h | 54 +++-------
drivers/infiniband/ulp/iser/iser_initiator.c | 70 +++++++++++--
drivers/infiniband/ulp/iser/iser_memory.c | 150 +++++++++------------------
drivers/infiniband/ulp/iser/iser_verbs.c | 30 ++++--
drivers/infiniband/ulp/isert/ib_isert.c | 73 +++++++++----
drivers/infiniband/ulp/isert/ib_isert.h | 40 ++++++-
drivers/infiniband/ulp/isert/isert_proto.h | 47 ---------
include/scsi/iser.h | 78 ++++++++++++++
9 files changed, 322 insertions(+), 229 deletions(-)
delete mode 100644 drivers/infiniband/ulp/isert/isert_proto.h
create mode 100644 include/scsi/iser.h
--
1.8.4.3
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
