On Thu, Nov 19, 2015 at 12:01 PM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > Internal code structure is one thing, ever supporting bidi is another > one. Without QUEUE_FLAG_BIDI a driver has never supported bidirectional > requests. And iSER never had that flag set in mainline. So even if you > spent of time supporting bidi in iSER it never was supported and all > that great support was entirely untested the last 10 years. Christoph, To make it clear iser's role is very well defined and strict w.r.t supporting bidis, we should on IO submission path 1. dma map the SC properly in, out, both or none 2. memory register what's needed 3. put in the iser header 1,2 or 0 keys on IO completion path 4. set a pointer to the iscsi response header etc 5. memory unregister what's needed 6. dma unmap properly 7. call up to the iscsi/scsi stack with that pointer anything else that I missed? AFAIK steps 1..7 were supported ok in the past, probably now not, we should fix at some point Or. -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
