On 11/17/2015 11:41 AM, Sagi Grimberg wrote:
what's the role of this hunk? why it belongs here? you are testing
device->mr but this is something global and has nothing to do
specially with specific IOs for
which this patch aims to act
It's because device->mr might not be allocated at all if
always_register=Y, however in this case for all-immediatedata writes
I don't need memory registration and I can use pd->local_dma_lkey.
This hunk prevents a NULL dereference (as I mentioned, device->mr might
not be allocated at all).
I am not sure to follow, but can't you put this fix into a separate
patch to make things more clearer?
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
