On Thu, Oct 22, 2015 at 05:29:36PM -0700, Greg Kroah-Hartman wrote: > On Thu, Oct 22, 2015 at 04:02:14PM -0700, Bart Van Assche wrote: > > The last user is gone. Hence remove this function. > > No, please don't do that, someone else will come along that will need it > someday, and it isn't hurting anything to keep it here. It bloats the kernel, and users should much better use kref_get_unless_zero which is easier to understand and has much better defined semantics. > Odds are, some in-kernel code should be converted to be using it to fix > race conditions anyway... Please not. Use kref_get_unless_zero and get rid of this thing before it grows another user. Consistency is good. -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
