On Thu, 2015-07-09 at 09:56 -0700, Andy Grover wrote:
> Here are some more instances where we are returning 0 from a configfs
> store function, the unintended result of which is likely infinite retries
> from userspace.
>
> Signed-off-by: Andy Grover <agrover@xxxxxxxxxx>
> ---
> drivers/target/target_core_configfs.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c
> index cb09e69..7f3cb3a 100644
> --- a/drivers/target/target_core_configfs.c
> +++ b/drivers/target/target_core_configfs.c
> @@ -1590,9 +1590,9 @@ static ssize_t target_core_dev_pr_store_attr_res_aptpl_metadata(
> u8 type = 0;
>
> if (dev->transport->transport_flags & TRANSPORT_FLAG_PASSTHROUGH)
> - return 0;
> + return count;
> if (dev->dev_reservation_flags & DRF_SPC2_RESERVATIONS)
> - return 0;
> + return count;
>
> if (dev->export_count) {
> pr_debug("Unable to process APTPL metadata while"
> @@ -1985,7 +1985,7 @@ static ssize_t target_core_store_alua_lu_gp(
>
> lu_gp_mem = dev->dev_alua_lu_gp_mem;
> if (!lu_gp_mem)
> - return 0;
> + return count;
>
> if (count > LU_GROUP_NAME_BUF) {
> pr_err("ALUA LU Group Alias too large!\n");
Likewise, thanks for auditing the helpers that are now used directly as
configfs_item_operations->store_attribute() callers.
Applied to target-pending/master.
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
