Hi Andy, On Thu, 2015-07-09 at 09:56 -0700, Andy Grover wrote: > See https://bugzilla.redhat.com/show_bug.cgi?id=1240687 > > Returning 0 from a configfs store function results in infinite retries. > > Reported-by: Yanko Kaneti <yaneti@xxxxxxxxxxx> > Signed-off-by: Andy Grover <agrover@xxxxxxxxxx> > --- > drivers/target/target_core_configfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c > index 0b0de36..cb09e69 100644 > --- a/drivers/target/target_core_configfs.c > +++ b/drivers/target/target_core_configfs.c > @@ -747,7 +747,7 @@ static ssize_t store_pi_prot_type(struct se_dev_attrib *da, > if (!dev->transport->init_prot || !dev->transport->free_prot) { > /* 0 is only allowed value for non-supporting backends */ > if (flag == 0) > - return 0; > + return count; > > pr_err("DIF protection not supported by backend: %s\n", > dev->transport->name); Nice catch on this one. Applied to target-pending/master, and will include for the next v4.2-rc PULL request. Thank you, --nab -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
