On Wed, Jul 1, 2015 at 7:30 PM, Steve Wise <swise@xxxxxxxxxxxxxxxxxxxxx> wrote:
please no empty change-logs for this driver (and elsewhere), find
something that fills @ least one sentence, it's easy.
Also, we are aiming to initiate (Sagi please make sure you follow on
this practice too) commit titles for the iser initiator with Capital
letter, so s/limit/Limit/g
> Signed-off-by: Steve Wise <swise@xxxxxxxxxxxxxxxxxxxxx>
> ---
> drivers/infiniband/ulp/iser/iscsi_iser.c | 7 +++++++
> 1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/infiniband/ulp/iser/iscsi_iser.c b/drivers/infiniband/ulp/iser/iscsi_iser.c
> index 6a594aa..ec692f7 100644
> --- a/drivers/infiniband/ulp/iser/iscsi_iser.c
> +++ b/drivers/infiniband/ulp/iser/iscsi_iser.c
> @@ -640,6 +640,13 @@ iscsi_iser_session_create(struct iscsi_endpoint *ep,
> SHOST_DIX_GUARD_CRC);
> }
>
> + /*
> + * Limit the sg_tablesize based on the device max fastreg page
> + * list length.
> + */
> + shost->sg_tablesize = min_t(u32, shost->sg_tablesize,
> + ib_conn->device->dev_attr.max_fast_reg_page_list_len);
> +
I guess you should also somehow recap shost->max_sectors (which is
hard coded to 1024 (== 512KB IO) now) for your needs.
> if (iscsi_host_add(shost,
> ib_conn->device->ib_device->dma_device)) {
> mutex_unlock(&iser_conn->state_mutex);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
