> -----Original Message----- > From: Sagi Grimberg [mailto:sagig@xxxxxxxxxxxxxxxxxx] > Sent: Wednesday, July 01, 2015 12:08 PM > To: Steve Wise; dledford@xxxxxxxxxx > Cc: roid@xxxxxxxxxxxx; linux-rdma@xxxxxxxxxxxxxxx; sagig@xxxxxxxxxxxx; infinipath@xxxxxxxxx; target-devel@xxxxxxxxxxxxxxx; > eli@xxxxxxxxxxxx; ogerlitz@xxxxxxxxxxxx > Subject: Re: [PATCH V3 3/4] RDMA/iser: limit sg tablesize to device fastreg max depth > > On 7/1/2015 7:30 PM, Steve Wise wrote: > > Signed-off-by: Steve Wise <swise@xxxxxxxxxxxxxxxxxxxxx> > > --- > > drivers/infiniband/ulp/iser/iscsi_iser.c | 7 +++++++ > > 1 files changed, 7 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/infiniband/ulp/iser/iscsi_iser.c b/drivers/infiniband/ulp/iser/iscsi_iser.c > > index 6a594aa..ec692f7 100644 > > --- a/drivers/infiniband/ulp/iser/iscsi_iser.c > > +++ b/drivers/infiniband/ulp/iser/iscsi_iser.c > > @@ -640,6 +640,13 @@ iscsi_iser_session_create(struct iscsi_endpoint *ep, > > SHOST_DIX_GUARD_CRC); > > } > > > > + /* > > + * Limit the sg_tablesize based on the device max fastreg page > > + * list length. > > + */ > > + shost->sg_tablesize = min_t(u32, shost->sg_tablesize, > > + ib_conn->device->dev_attr.max_fast_reg_page_list_len); > > + > > if (iscsi_host_add(shost, > > ib_conn->device->ib_device->dma_device)) { > > mutex_unlock(&iser_conn->state_mutex); > > > > You forgot to add my Reviewed-by on this. > > So again (for patchworks), > > Reviewed-by: Sagi Grimberg <sagig@xxxxxxxxxxxx> My bad...Sorry Sagi! -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
