Hi Christoph, On Wed, May 20, 2015 at 06:09PM, Christoph Hellwig wrote: > On Wed, May 20, 2015 at 04:20:05PM +0300, Ilias Tsitsimpis wrote: > > I don't understand why this is needed. First of all, I would suggest > > rephrasing the comment since it seems to have a few problems (it took me > > a while to understand it). Also, since this is a pass-through SCSI > > implementation, you shouldn't have to examine the CDB or modify it in > > any way. What do you think? > > This is because SCSI-2 sets the lun in the second cdb byte. On the > other hand I don't think exporting anything as SCSI-2 from the Linux > target makes sense, so maybe we can drop it these days? Thanks for the explanation. I do believe that this needs to go, since a pass-through SCSI implementation should not modify the CDB, but as I said to Andy let's fix this in the next merge window. Cheers, Ilias
Attachment:
signature.asc
Description: Digital signature
