On Wed, May 20, 2015 at 04:08:54PM +0300, Ilias Tsitsimpis wrote: > Why does hw_block_size need to be configurable via dev params? Since > TCMU is now a full pass-through SCSI implementation, userspace gets to > answer the READ CAPACITY command and decide the hw_block_size itself. > Setting this parameter to a value (say 512) has no effect if the TCMU > handler replies to the READ CAPACITY command with a different value. Agreed, having to configure the block size seems odd. But maybe it's my fault because I suggested to keep the attributes the same as pscsi? To be honest having this in pscsi seems broken, but given that pscsi doesn't handle non-disk devices well no one might have noticed. Nic, any reason we bother with exposting the block size attribute for pscsi? -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
