On Tue, May 19, 2015 at 02:44PM, Andy Grover wrote: > After much discussion, give up on only passing a subset of SCSI commands > to userspace and pass them all. Based on what pscsi is doing, make sure > to set SCF_SCSI_DATA_CDB for I/O ops, and define attributes identical to > pscsi. > > Make hw_block_size configurable via dev param. Hi Andy, Why does hw_block_size need to be configurable via dev params? Since TCMU is now a full pass-through SCSI implementation, userspace gets to answer the READ CAPACITY command and decide the hw_block_size itself. Setting this parameter to a value (say 512) has no effect if the TCMU handler replies to the READ CAPACITY command with a different value. Cheers, Ilias > Remove mention of command filtering from tcmu-design.txt. > > Signed-off-by: Andy Grover <agrover@xxxxxxxxxx>
Attachment:
signature.asc
Description: Digital signature
