Re: [RFC PATCHv2 1/2] target: Version 2 of TCMU ABI

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/30/2015 12:18 AM, Christoph Hellwig wrote:
On Wed, Apr 22, 2015 at 08:45:08PM +0200, Christoph Hellwig wrote:
On Wed, Apr 22, 2015 at 11:35:30AM -0700, Andy Grover wrote:
Change se_subsystem_api.transport_type from a field into a *function that
takes a *se_device parameter?

Doesn't work.  The attributes are set up earlier than the arguments
for the backend driver are parsed.  I think the only sensible
option is to have two different templates for these two very different bits of
funtionality.

Andy, any opinion on how we should fix this?  I'd really prefer to not
release the second TCMU version in 4.1 which will need breaking fixes
again soon after.

For now the simplest fix might be to just register the level you
actually plan on using for now, and then add a second template once
people need the other one and actually have tested code for it.

OK. Sorry for being slow. I'll post a little patch shortly to disallow pass_level=0 (full pass-thru) for now, and that will give me more time to develop and test a proper fix that will allow the use of pass_level=0 again.

-- Andy
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux