Re: [PATCH] target: simplify the target template registration API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2015-04-06 at 17:52 +0200, Christoph Hellwig wrote:
> On Thu, Mar 26, 2015 at 03:00:46PM -0700, Nicholas A. Bellinger wrote:
> > Just a heads up that I've got a ~20 part series in target-rcu-wip to
> > convert se_node_acl->device_list[] access to RCU, along with a number of
> > other cleanups along with the long overdue renaming of core_tpg_* +
> > core_dev_* to target_* prefixes.
> > 
> > This patch most certainly conflicts with that series..  Any chance to
> > rebase this against target-rcu-wip..?
> 
> Seems rather pointless to rebase it on the renames, which are the only
> part affected.  I'd prefer to merge this patch ASAP

So I was going to just merge this because having a single register
template function for fabric drivers does make alot of sense, but it
currently conflicts with the T10-PI fabric bits in for-next.  Sigh..

Looking further, I really don't like how the target_fabric_copy_attrs()
stuff works in target_register_template().  Just punting to direct use
struct configfs_attributes pointers in target_core_fabric_ops is a hack.

I'd much rather see target_fabric_setup_cits() do this proper setup,
instead of unnecessarily duplicating the target_core_fabric_configfs.c
list of defined config_item_types in two new locations.

--nab

--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux